Repository navigation
fix: allow specifying DRM_EXPORTER_ADDRESS - #123
Closed
neutralalice wants to merge 2 commits into
Closed
neutralalice wants to merge 2 commits into
neutralalice wants to merge 2 commits into
Conversation
Contributor
|
Thanks for this, but I have decided to merge in #124 to fix this instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
enables specifying DRM_EXPORTER_ADDRESS as a value for the helm chart
Additional information
I run ipv6 first for most of my homelab, so noticed probes were failing on this daemonset.
The value is currently hardcoded as 0.0.0.0 in the chart template. As described
drm-exporter/src/cli.rs
Line 25 in 7a2717d
I tested that :: is working just by switching a running daemonset existing 0.0.0.0 address to :: and it worked picked up right away.
zero AI used at any stage from investigation to submission.
Requirements